Horton

Refactor code in charge of grabbing the relations of a subscription

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: ce3049b0215b63744d11c0ce3ac6afdb67fc2ff0
Author: Michael Paquier <michael@paquier.xyz>
Date: 2022-07-27T10:50:06Z
Releases: 16.0 
Refactor code in charge of grabbing the relations of a subscription

GetSubscriptionRelations() and GetSubscriptionNotReadyRelations() share
mostly the same code, which scans pg_subscription_rel and fetches all
the relations of a given subscription.  The only difference is that the
second routine looks for all the relations not in a ready state.  This
commit refactors the code to use a single routine, shaving a bit of
code.

Author: Vignesh C
Reviewed-By: Kyotaro Horiguchi, Amit Kapila, Michael Paquier, Peter
Smith
Discussion: https://postgr.es/m/CALDaNm0eW-9g4G_EzHebnFT5zZoasWCS_EzZQ5BgnLZny9S=pg@mail.gmail.com

Files

PathChange+/−
src/backend/catalog/pg_subscription.c modified +10 −60
src/backend/commands/subscriptioncmds.c modified +2 −2
src/backend/replication/logical/tablesync.c modified +1 −1
src/include/catalog/pg_subscription_rel.h modified +1 −2

Discussion