Fix failure of btree_gin indexscans with "char" type and </<= operators.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: cd7d9b6b63f1ed1d60cab3888eb0fc2523de6f0e
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-08-10T22:10:30Z
Releases: 12.9
Fix failure of btree_gin indexscans with "char" type and </<= operators.

As a result of confusion about whether the "char" type is signed or
unsigned, scans for index searches like "col < 'x'" or "col <= 'x'"
would start at the middle of the index not the left end, thus missing
many or all of the entries they should find.  Fortunately, this
is not a symptom of index corruption.  It's only the search logic
that is broken, and we can fix it without unpleasant side-effects.

Per report from Jason Kim.  This has been wrong since btree_gin's
beginning, so back-patch to all supported branches.

Discussion: https://postgr.es/m/20210810001649.htnltbh7c63re42p@jasonk.me

Files

PathChange+/−
contrib/btree_gin/btree_gin.c modified +1 −1
contrib/btree_gin/expected/char.out modified +9 −2

Discussion