Horton

SQL/JSON: Fix JSON_TABLE() column deparsing

Amit Langote <amitlan@postgresql.org>

View on postgr.es
Commit: cd680b39211c5c3c88a143abcac576a22f996d7a
Author: Amit Langote <amitlan@postgresql.org>
Date: 2024-09-06T04:30:40Z
Releases: 17.0 
SQL/JSON: Fix JSON_TABLE() column deparsing

The deparsing code in get_json_expr_options() unnecessarily emitted
the default column-specific ON ERROR / EMPTY behavior when the
top-level ON ERROR behavior in JSON_TABLE was set to ERROR. Fix that
by not overriding the column-specific default, determined based on
the column's JsonExprOp in get_json_table_columns(), with
JSON_BEHAVIOR_ERROR when that is the top-level ON ERROR behavior.

Note that this only removes redundancy; the current deparsing output
is not incorrect, just redundant.

Reviewed-by: Jian He <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com
Backpatch-through: 17

Files

PathChange+/−
src/backend/utils/adt/ruleutils.c modified +4 −4
src/test/regress/expected/sqljson_jsontable.out modified +23 −0
src/test/regress/sql/sqljson_jsontable.sql modified +10 −0

Discussion