Fix bug in SetOffsetVacuumLimit() triggered by find_multixact_start() failure.

Andres Freund <andres@anarazel.de>

Commit: ccde00b9b97ed8b7307e39f95bd48922bf955bb2
Author: Andres Freund <andres@anarazel.de>
Date: 2015-12-14T10:34:50Z
Releases: 9.5.0
Fix bug in SetOffsetVacuumLimit() triggered by find_multixact_start() failure.

Previously, if find_multixact_start() failed, SetOffsetVacuumLimit() would
install 0 into MultiXactState->offsetStopLimit if it previously succeeded.
Luckily, there are no known cases where find_multixact_start() will return
an error in 9.5 and above. But if it were to happen, for example due to
filesystem permission issues, it'd be somewhat bad: GetNewMultiXactId()
could continue allocating mxids even if close to a wraparound, or it could
erroneously stop allocating mxids, even if no wraparound is looming.  The
wrong value would be corrected the next time SetOffsetVacuumLimit() is
called, or by a restart.

Reported-By: Noah Misch, although this is not his preferred fix
Discussion: 20151210140450.GA22278@alap3.anarazel.de
Backpatch: 9.5, where the bug was introduced as part of 4f627f

Files

PathChange+/−
src/backend/access/transam/multixact.c modified +6 −2