Second try at fixing tcp_keepalives_idle option on Solaris.
Tom Lane <tgl@sss.pgh.pa.us>
Second try at fixing tcp_keepalives_idle option on Solaris. Buildfarm evidence shows that TCP_KEEPALIVE_THRESHOLD doesn't exist after all on Solaris < 11. This means we need to take positive action to prevent the TCP_KEEPALIVE code path from being taken on that platform. I've chosen to limit it with "&& defined(__darwin__)", since it's unclear that anyone else would follow Apple's precedent of spelling the symbol that way. Also, follow a suggestion from Michael Paquier of eliminating code duplication by defining a couple of intermediate symbols for the socket option. In passing, make some effort to reduce the number of translatable messages by replacing "setsockopt(foo) failed" with "setsockopt(%s) failed", etc, throughout the affected files. And update relevant documentation so that it doesn't claim to provide an exhaustive list of the possible socket option names. Like the previous commit (f0256c774), back-patch to all supported branches. Discussion: https://postgr.es/m/20170627163757.25161.528@wrigleys.postgresql.org
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/config.sgml | modified | +9 −8 |
| doc/src/sgml/libpq.sgml | modified | +10 −9 |
| src/backend/libpq/pqcomm.c | modified | +40 −58 |
| src/interfaces/libpq/fe-connect.c | modified | +29 −31 |
Discussion
- BUG #14720: getsockopt(TCP_KEEPALIVE) failed: Option not supported by protocol 7 messages · 2017-06-27 → 2017-06-28