pg_stat_wal: Accumulate time as instr_time instead of microseconds
Andres Freund <andres@anarazel.de>
pg_stat_wal: Accumulate time as instr_time instead of microseconds In instr_time.h it is stated that: * When summing multiple measurements, it's recommended to leave the * running sum in instr_time form (ie, use INSTR_TIME_ADD or * INSTR_TIME_ACCUM_DIFF) and convert to a result format only at the end. The reason for that is that converting to microseconds is not cheap, and can loose precision. Therefore this commit changes 'PendingWalStats' to use 'instr_time' instead of 'PgStat_Counter' while accumulating 'wal_write_time' and 'wal_sync_time'. Author: Nazir Bilal Yavuz <byavuz81@gmail.com> Reviewed-by: Andres Freund <andres@anarazel.de> Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com> Reviewed-by: Melanie Plageman <melanieplageman@gmail.com> Discussion: https://postgr.es/m/1feedb83-7aa9-cb4b-5086-598349d3f555@gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/transam/xlog.c | modified | +2 −4 |
| src/backend/storage/file/buffile.c | modified | +2 −4 |
| src/backend/utils/activity/pgstat_wal.c | modified | +16 −15 |
| src/include/pgstat.h | modified | +16 −1 |
| src/tools/pgindent/typedefs.list | modified | +1 −0 |
Discussion
- Refactor calculations to use instr_time 11 messages · 2023-02-16 → 2023-03-30