Horton

Fix tablespace handling for partitioned tables

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: ca4103025dfe26eaaf6a500dec9170fbb176eebc
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2018-12-17T18:37:40Z
Releases: 12.0 
Fix tablespace handling for partitioned tables

When partitioned tables were introduced, we failed to realize that by
copying the tablespace handling for other relation kinds with no
physical storage we were causing the secondary effect that their
partitions would not automatically inherit the tablespace setting.  This
is surprising and unhelpful, so change it to adopt the behavior
introduced in pg11 (commit 33e6c34c3267) for partitioned indexes: the
parent relation remembers the tablespace specification, which is then
used for any new partitions that don't declare one.

Because this commit changes behavior of the TABLESPACE clause for
partitioned tables (it's no longer a no-op), it is not backpatched.

Author: David Rowley, Álvaro Herrera
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/CAKJS1f9SxVzqDrGD1teosFd6jBMM0UEaa14_8mRvcWE19Tu0hA@mail.gmail.com

Files

PathChange+/−
doc/src/sgml/ref/create_table.sgml modified +5 −1
src/backend/catalog/heap.c modified +3 −3
src/backend/commands/tablecmds.c modified +95 −57
src/include/catalog/pg_class.h modified +13 −0
src/test/regress/input/tablespace.source modified +12 −0
src/test/regress/output/tablespace.source modified +19 −0

Documentation touched

Discussion