Extend ExecBuildAggTrans() to support a NULL pointer check.
Jeff Davis <jdavis@postgresql.org>
Extend ExecBuildAggTrans() to support a NULL pointer check. Optionally push a step to check for a NULL pointer to the pergroup state. This will be important for disk-based hash aggregation in combination with grouping sets. When memory limits are reached, a given tuple may find its per-group state for some grouping sets but not others. For the former, it advances the per-group state as normal; for the latter, it skips evaluation and the calling code will have to spill the tuple and reprocess it in a later batch. Add the NULL check as a separate expression step because in some common cases it's not needed. Discussion: https://postgr.es/m/20200221202212.ssb2qpmdgrnx52sj%40alap3.anarazel.de
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/executor/execExpr.c | modified | +34 −5 |
| src/backend/executor/execExprInterp.c | modified | +17 −0 |
| src/backend/executor/nodeAgg.c | modified | +2 −1 |
| src/backend/jit/llvm/llvmjit_expr.c | modified | +39 −0 |
| src/include/executor/execExpr.h | modified | +8 −0 |
| src/include/executor/executor.h | modified | +1 −1 |
Discussion
- Memory-Bounded Hash Aggregation 81 messages · 2019-07-01 → 2020-03-28