Horton

Fix determination of not-null constraint "locality" for inherited columns

Álvaro Herrera <alvherre@kurilemu.de>

View on postgr.es
Commit: c945b06d5f03e30cec279df516688c70787b2b2c
Author: Álvaro Herrera <alvherre@kurilemu.de>
Date: 2025-10-18T16:18:19Z
Releases: 17.7 
Fix determination of not-null constraint "locality" for inherited columns

It is possible to have a non-inherited not-null constraint on an
inherited column, but we were failing to preserve such constraints
during pg_upgrade where the source is 17 or older, because of a bug in
the pg_dump query for it.  Oversight in commit 14e87ffa5c54.  Fix that
query.  In passing, touch-up a bogus nearby comment introduced by the
same commit.

In version 17, make the regression tests leave a table in this
situation, so that this scenario is tested in the cross-version upgrade
tests of 18 and up.

Author: Dilip Kumar <dilipbalaut@gmail.com>
Reported-by: Andrew Bille <andrewbille@gmail.com>
Bug: #19074
Backpatch-through: 18
Discussion: https://postgr.es/m/19074-ae2548458cf0195c@postgresql.org

Files

PathChange+/−
src/test/regress/expected/constraints.out modified +4 −0
src/test/regress/sql/constraints.sql modified +5 −0

Discussion