Undo faulty attempt at not relying on RINFO_IS_PUSHED_DOWN.
Tom Lane <tgl@sss.pgh.pa.us>
Undo faulty attempt at not relying on RINFO_IS_PUSHED_DOWN. I've had a bee in my bonnet for some time about getting rid of RestrictInfo.is_pushed_down, because it's squishily defined and requires not-inexpensive extra tests to use (cf RINFO_IS_PUSHED_DOWN). In commit 2489d76c4, I tried to make remove_rel_from_query() not depend on that macro; but the replacement test is buggy, as exposed by a report from Rushabh Lathia and Robert Haas. That change was pretty incidental to the main goal of 2489d76c4, so let's just revert it for now. (Getting rid of is_pushed_down is still far away, anyway.) Discussion: https://postgr.es/m/CA+TgmoYco=hmg+iX1CW9Y1_CzNoSL81J03wUG-d2_3=rue+L2A@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/optimizer/plan/analyzejoins.c | modified | +1 −6 |
| src/test/regress/expected/join.out | modified | +16 −0 |
| src/test/regress/sql/join.sql | modified | +6 −0 |
Discussion
- v16 regression - wrong query results with LEFT JOINs + join removal 9 messages · 2023-05-11 → 2023-05-12