Fix some jsonb issues found by Coverity in recent commits.

Andrew Dunstan <andrew@dunslane.net>

Commit: c8315930e6a34b616d9840985c85eb0d856dd2df
Author: Andrew Dunstan <andrew@dunslane.net>
Date: 2014-12-16T15:32:06Z
Releases: 9.5.0
Fix some jsonb issues found by Coverity in recent commits.

Mostly these issues concern the non-use of function results. These
have been changed to use (void) pushJsonbValue(...) instead of assigning
the result to a variable that gets overwritten before it is used.

There is a larger issue that we should possibly examine the API for
pushJsonbValue(), so that instead of returning a value it modifies a
state argument. The current idiom is rather clumsy. However, changing
that requires quite a bit more work, so this change should do for the
moment.

Files

PathChange+/−
src/backend/utils/adt/jsonb.c modified +8 −8
src/backend/utils/adt/jsonfuncs.c modified +3 −1