Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation

Neil Conway <neilc@samurai.com>

Commit: c556b29a1199babc672b81065fe74fb50657c451
Author: Neil Conway <neilc@samurai.com>
Date: 2007-08-08T18:07:05Z
Releases: 8.3.0
Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation
hash table is allocated in a child context of the agg node's memory
context, MemoryContextReset() will reset but *not* delete the child
context. Since ExecReScanAgg() proceeds to build a new hash table
from scratch (in a new sub-context), this results in leaking the
header for the previous memory context. Therefore, use
MemoryContextResetAndDeleteChildren() instead.

Credit: My colleague Sailesh Krishnamurthy at Truviso for isolating
the cause of the leak.

Files

PathChange+/−
src/backend/executor/nodeAgg.c modified +9 −3