Horton

Move TupleTableSlots boolean member into one flag variable.

Andres Freund <andres@anarazel.de>

View on postgr.es
Commit: c5257345ef61922468cd9abd887c3cb6c38792cb
Author: Andres Freund <andres@anarazel.de>
Date: 2018-10-16T01:23:25Z
Releases: 12.0 
Move TupleTableSlots boolean member into one flag variable.

There's several reasons for this change:
1) It reduces the total size of TupleTableSlot / reduces alignment
   padding, making the commonly accessed members fit into a single
   cacheline (but we currently do not force proper alignment, so
   that's not yet guaranteed to be helpful)
2) Combining the booleans into a flag allows to combine read/writes
   from memory.
3) With the upcoming slot abstraction changes, it allows to have core
   and extended flags, in a memory efficient way.

Author: Ashutosh Bapat and Andres Freund
Discussion: https://postgr.es/m/20180220224318.gw4oe5jadhpmcdnm@alap3.anarazel.de

Files

PathChange+/−
src/backend/access/common/heaptuple.c modified +5 −2
src/backend/executor/execTuples.c modified +58 −38
src/backend/executor/nodeAgg.c modified +1 −1
src/backend/executor/nodeModifyTable.c modified +1 −1
src/backend/jit/llvm/llvmjit_deform.c modified +6 −3
src/backend/jit/llvm/llvmjit_expr.c modified +2 −2
src/include/executor/executor.h modified +1 −1
src/include/executor/tuptable.h modified +42 −24

Discussion