Code review for improved-hashing patch. Fix some portability issues
Tom Lane <tgl@sss.pgh.pa.us>
Code review for improved-hashing patch. Fix some portability issues (char != unsigned char, Datum != uint32); make use of new hash code in dynahash hash tables and hash joins.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/hash/hash.c | modified | +4 −1 |
| src/backend/access/hash/hashfunc.c | modified | +57 −56 |
| src/backend/executor/nodeHash.c | modified | +16 −21 |
| src/backend/utils/adt/date.c | modified | +2 −2 |
| src/backend/utils/adt/mac.c | modified | +2 −2 |
| src/backend/utils/adt/timestamp.c | modified | +2 −2 |
| src/backend/utils/adt/varchar.c | modified | +2 −2 |
| src/backend/utils/hash/dynahash.c | modified | +8 −9 |
| src/backend/utils/hash/hashfn.c | modified | +7 −79 |
| src/include/access/hash.h | modified | +4 −3 |
| src/include/utils/hsearch.h | modified | +10 −13 |