Horton

Fix logical replication slot initialization

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: c40489e449ea08e154cd62fa055785873f7bdac8
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2018-08-01T21:47:15Z
Releases: 12.0 
Fix logical replication slot initialization

This was broken in commit 9c7d06d60680, which inadvertently gave the
wrong value to fast_forward in one StartupDecodingContext call.  Fix by
flipping the value.  Add a test for the obvious error, namely trying to
initialize a replication slot with an nonexistent output plugin.

While at it, move the CreateDecodingContext call earlier, so that any
errors are reported before sending the CopyBoth message.

Author: Dave Cramer <davecramer@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CADK3HHLVkeRe1v4P02-5hj55H3_yJg3AEtpXyEY5T3wuzO2jSg@mail.gmail.com

Files

PathChange+/−
contrib/test_decoding/expected/slot.out modified +2 −0
contrib/test_decoding/sql/slot.sql modified +2 −0
src/backend/replication/logical/logical.c modified +1 −1
src/backend/replication/walsender.c modified +13 −10

Discussion