Horton

Avoid casting void * function arguments

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: c3c240537f6da498186bfb07017a7b01b9a2c24f
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2026-01-12T15:12:56Z
Releases: 19 (unreleased) 
Avoid casting void * function arguments

In many cases, the cast would silently drop a const qualifier.  To
fix, drop the unnecessary cast and let the compiler check the types
and qualifiers.  Add const to read-only local variables, preserving
the const qualifiers from the function signatures.

Co-authored-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Co-authored-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/aUQHy/MmWq7c97wK%40ip-10-97-1-34.eu-west-3.compute.internal

Files

PathChange+/−
src/backend/access/brin/brin_minmax_multi.c modified +6 −6
src/backend/access/common/heaptuple.c modified +3 −3
src/backend/access/heap/pruneheap.c modified +2 −2
src/backend/access/nbtree/nbtpage.c modified +2 −2
src/backend/access/nbtree/nbtpreprocesskeys.c modified +2 −2
src/backend/access/nbtree/nbtsplitloc.c modified +2 −2
src/backend/access/spgist/spgkdtreeproc.c modified +4 −4
src/backend/statistics/extended_stats.c modified +2 −2
src/backend/statistics/mcv.c modified +4 −4
src/backend/tsearch/spell.c modified +2 −2
src/backend/utils/adt/rangetypes_gist.c modified +9 −9
src/backend/utils/adt/rangetypes_spgist.c modified +3 −3
src/backend/utils/adt/rangetypes_typanalyze.c modified +3 −3
src/backend/utils/cache/typcache.c modified +7 −7
src/bin/pg_dump/pg_dump.c modified +1 −1
src/test/modules/injection_points/injection_points.c modified +6 −6

Discussion