Remove table AM callback scan_bitmap_next_block
Melanie Plageman <melanieplageman@gmail.com>
Remove table AM callback scan_bitmap_next_block After pushing the bitmap iterator into table-AM specific code (as part of making bitmap heap scan use the read stream API in 2b73a8cd33b7), scan_bitmap_next_block() no longer returns the current block number. Since scan_bitmap_next_block() isn't returning any relevant information to bitmap table scan code, it makes more sense to get rid of it. Now, bitmap table scan code only calls table_scan_bitmap_next_tuple(), and the heap AM implementation of scan_bitmap_next_block() is a local helper in heapam_handler.c. Reviewed-by: Tomas Vondra <tomas@vondra.me> Discussion: https://postgr.es/m/flat/CAAKRu_ZwCwWFeL_H3ia26bP2e7HiKLWt0ZmGXPVwPO6uXq0vaA%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/heap/heapam_handler.c | modified | +196 −176 |
| src/backend/access/table/tableamapi.c | modified | +0 −3 |
| src/backend/executor/nodeBitmapHeapscan.c | modified | +24 −49 |
| src/backend/optimizer/util/plancat.c | modified | +1 −1 |
| src/include/access/tableam.h | modified | +23 −67 |
Discussion
Cited messages not in the archive:
flat/CAAKRu_ZwCwWFeL_H3ia26bP2e7HiKLWt0ZmGXPVwPO6uXq0vaA@mail.gmail.com