Horton

Consolidate cross-option checks in pg_restore

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: c34bca9ea55e1d7c207ebc30691a8d2b421100eb
Author: Michael Paquier <michael@paquier.xyz>
Date: 2018-10-30T02:38:35Z
Releases: 12.0 
Consolidate cross-option checks in pg_restore

This moves one check for conflicting options from the archive restore
code to the main function where other similar checks are performed.
Also reword the error message to be consistent with other messages.

The only option combination impacted is --create specified with
--single-transaction, and informing the caller at an early step saves
from opening the archive worked on.  A TAP test is added for this
combination.

Author: Daniel Gustafsson
Reviewed-by: Fabien Coelho
Discussion: https://postgr.es/m/616808BD-4B59-4E6C-97A9-7317F62D5570@yesql.se

Files

PathChange+/−
src/bin/pg_dump/pg_backup_archiver.c modified +0 −9
src/bin/pg_dump/pg_restore.c modified +11 −0
src/bin/pg_dump/t/001_basic.pl modified +7 −1

Discussion