Fixup some misusages of bms_num_members()

David Rowley <drowley@postgresql.org>

Commit: c34605daed563fcade07a9f45bcf440459599c00
Author: David Rowley <drowley@postgresql.org>
Date: 2020-08-25T22:51:36Z
Releases: 14.0
Fixup some misusages of bms_num_members()

It's a bit inefficient to test if a Bitmapset is empty by counting all the
members and seeing if that number is zero. It's much better just to use
bms_is_empty().  Likewise for checking if there are at least two members,
just use bms_membership(), which does not need to do anything more after
finding two members.

Discussion: https://postgr.es/m/CAApHDvpvwm_QjbDOb5xga%2BKmX9XkN9xQavNGm3SvDbVnCYOerQ%40mail.gmail.com
Reviewed-by: Tomas Vondra

Files

Discussion