Fix UPDATE/DELETE WHERE CURRENT OF to support repeated update and update-
Tom Lane <tgl@sss.pgh.pa.us>
Fix UPDATE/DELETE WHERE CURRENT OF to support repeated update and update- then-delete on the current cursor row. The basic fix is that nodeTidscan.c has to apply heap_get_latest_tid() to the current-scan-TID obtained from the cursor query; this ensures we get the latest row version to work with. However, since that only works if the query plan is a TID scan, we also have to hack the planner to make sure only that type of plan will be selected. (Formerly, the planner might decide to apply a seqscan if the table is very small. This change is probably a Good Thing anyway, since it's hard to see how a seqscan could really win.) That means the execQual.c code to support CurrentOfExpr as a regular expression type is dead code, so replace it with just an elog(). Also, add regression tests covering these cases. Note that the added tests expose the fact that re-fetching an updated row misbehaves if the cursor used FOR UPDATE. That's an independent bug that should be fixed later. Per report from Dharmendra Goyal.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/executor/execQual.c | modified | +6 −34 |
| src/backend/executor/nodeTidscan.c | modified | +17 −2 |
| src/backend/optimizer/path/costsize.c | modified | +26 −6 |
| src/include/nodes/execnodes.h | modified | +3 −1 |
| src/test/regress/expected/portals.out | modified | +133 −0 |
| src/test/regress/sql/portals.sql | modified | +40 −0 |