Fix query-lifespan memory leakage in repeatedly executed hash joins.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: c17a58967d97461a088ca2f19da4c46cf35e4194
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2018-03-16T20:03:45Z
Releases: 9.5.13
Fix query-lifespan memory leakage in repeatedly executed hash joins.

ExecHashTableCreate allocated some memory that wasn't freed by
ExecHashTableDestroy, specifically the per-hash-key function information.
That's not a huge amount of data, but if one runs a query that repeats
a hash join enough times, it builds up.  Fix by arranging for the data
in question to be kept in the hashtable's hashCxt instead of leaving it
"loose" in the query-lifespan executor context.  (This ensures that we'll
also clean up anything that the hash functions allocate in fn_mcxt.)

Per report from Amit Khandekar.  It's been like this forever, so back-patch
to all supported branches.

Discussion: https://postgr.es/m/CAJ3gD9cFofAWGvcxLOxDHC=B0hjtW8yGmUsF2hdGh97CM38=7g@mail.gmail.com

Files

PathChange+/−
src/backend/executor/nodeHash.c modified +22 −21

Discussion