Remove PG_MMAP_FLAGS from mem.h
Michael Paquier <michael@paquier.xyz>
Remove PG_MMAP_FLAGS from mem.h Based on name of the macro, it was implied that it could be used for all mmap() calls on portability grounds. However, its use is limited to sysv_shmem.c, for CreateAnonymousSegment(). This commit removes the declaration, reducing the confusion around it as a portability tweak, being limited to SysV-style shared memory. This macro has been introduced in b0fc0df9364d for sysv_shmem.c, originally. It has been moved to mem.h in 0ac5e5a7e152 a bit later. Suggested by: Peter Eisentraut <peter@eisentraut.org> Author: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Discussion: https://postgr.es/m/CAExHW5vTWABxuM5fbQcFkGuTLwaxuZDEE2vtx2WuMUWk6JnF4g@mail.gmail.com Discussion: https://postgr.es/m/12add41a-7625-4639-a394-a5563e349322@eisentraut.org
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/port/sysv_shmem.c | modified | +5 −4 |
| src/include/portability/mem.h | modified | +0 −2 |
Discussion
- Changing shared_buffers without restart 153 messages · 2024-10-18 → 2026-02-13
- Remove PG_MMAP_FLAGS 9 messages · 2026-01-22 → 2026-01-27