Horton

Fix reporting of violations in ExecConstraints, again.

Robert Haas <rhaas@postgresql.org>

View on postgr.es
Commit: c0a8ae7be392aa09dd7e148ff662013e8e148893
Author: Robert Haas <rhaas@postgresql.org>
Date: 2017-04-10T16:20:08Z
Releases: 10.0 
Fix reporting of violations in ExecConstraints, again.

We decided in f1b4c771ea74f42447dccaed42ffcdcccf3aa694 to pass the
original slot to ExecConstraints(), but that breaks when there are
BEFORE ROW triggers involved.  So we need to do reverse-map the tuples
back to the original descriptor instead, as Amit originally proposed.

Amit Langote, reviewed by Ashutosh Bapat.  One overlooked comment
fixed by me.

Discussion: http://postgr.es/m/b3a17254-6849-e542-2353-bde4e880b6a4@lab.ntt.co.jp

Files

PathChange+/−
src/backend/commands/copy.c modified +2 −4
src/backend/executor/execMain.c modified +47 −11
src/backend/executor/execReplication.c modified +2 −2
src/backend/executor/nodeModifyTable.c modified +3 −4
src/include/executor/executor.h modified +1 −2
src/test/regress/expected/insert.out modified +18 −3
src/test/regress/sql/insert.sql modified +19 −2

Discussion