Change the interpretation of the primary_key_attnums parameter of

Tom Lane <tgl@sss.pgh.pa.us>

Commit: c0989c67fa8fcc53f8475bbc918e330588628cff
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2010-06-15T20:29:01Z
Releases: 9.0.0
Change the interpretation of the primary_key_attnums parameter of
dblink_build_sql_insert() and related functions.  Now the column numbers
are treated as logical not physical column numbers.  This will provide saner
behavior in the presence of dropped columns; furthermore, if we ever get
around to allowing rearrangement of logical column ordering, the original
definition would become nearly untenable from a usability standpoint.
Per recent discussion of dblink's handling of dropped columns.
Not back-patched for fear of breaking existing applications.

Files

PathChange+/−
contrib/dblink/dblink.c modified +27 −5
contrib/dblink/expected/dblink.out modified +3 −3
contrib/dblink/sql/dblink.sql modified +3 −3
doc/src/sgml/dblink.sgml modified +52 −6