Preventive maintenance in advance of pgindent run.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: c079673dcb7f210617c9fc1470e6bf166d8a2971

Author: Tom Lane <tgl@sss.pgh.pa.us>

Date: 2017-05-17T00:36:35Z

Preventive maintenance in advance of pgindent run.

Reformat various places in which pgindent will make a mess, and
fix a few small violations of coding style that I happened to notice
while perusing the diffs from a pgindent dry run.

There is one actual bug fix here: the need-to-enlarge-the-buffer code
path in icu_convert_case was obviously broken.  Perhaps it's unreachable
in our usage?  Or maybe this is just sadly undertested.

Files

Path	Change	+/−
contrib/btree_gist/btree_utils_num.c	modified	+7 −4
src/backend/catalog/pg_publication.c	modified	+5 −6
src/backend/commands/publicationcmds.c	modified	+3 −1
src/backend/commands/subscriptioncmds.c	modified	+1 −0
src/backend/executor/nodeNamedtuplestorescan.c	modified	+1 −0
src/backend/replication/logical/snapbuild.c	modified	+1 −1
src/backend/replication/pgoutput/pgoutput.c	modified	+3 −2
src/backend/tsearch/wparser.c	modified	+8 −5
src/backend/utils/adt/formatting.c	modified	+24 −11
src/backend/utils/adt/pg_locale.c	modified	+2 −0
src/bin/pg_basebackup/pg_basebackup.c	modified	+12 −12
src/bin/pg_dump/dumputils.c	modified	+1 −2
src/bin/pg_dump/pg_backup_archiver.h	modified	+2 −2
src/bin/pg_waldump/pg_waldump.c	modified	+9 −9
src/bin/psql/tab-complete.c	modified	+4 −3
src/common/scram-common.c	modified	+2 −1
src/include/catalog/pg_authid.h	modified	+7 −9
src/include/catalog/pg_subscription_rel.h	modified	+7 −7
src/include/replication/logicalproto.h	modified	+4 −2
src/interfaces/libpq/libpq-int.h	modified	+2 −2