Horton

Clean up ancient test style

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: c06d6aa4c35177655e0fd4acaca888a73c3f9845
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2020-12-15T21:03:39Z
Releases: 14.0 
Clean up ancient test style

Many older tests where written in a style like

    SELECT '' AS two, i.* FROM INT2_TBL

where the first column indicated the number of expected result rows.
This has gotten increasingly out of date, as the test data fixtures
have expanded, so a lot of these were wrong and misleading.  Moreover,
this style isn't really necessary, since the psql output already shows
the number of result rows.

To clean this up, remove all those extra columns.

Discussion: https://www.postgresql.org/message-id/flat/1a25312b-2686-380d-3c67-7a69094a999f%40enterprisedb.com

Files

PathChange+/−
src/test/regress/expected/boolean.out modified +128 −128
src/test/regress/expected/box.out modified +112 −112
src/test/regress/expected/case.out modified +60 −60
src/test/regress/expected/char_1.out modified +56 −56
src/test/regress/expected/char_2.out modified +56 −56
src/test/regress/expected/char.out modified +56 −56
src/test/regress/expected/circle.out modified +58 −58
src/test/regress/expected/float4-misrounded-input.out modified +94 −94
src/test/regress/expected/float4.out modified +94 −94
src/test/regress/expected/float8.out modified +147 −147
src/test/regress/expected/geometry.out modified +458 −458
src/test/regress/expected/horology.out modified +1327 −1327
src/test/regress/expected/inet.out modified +152 −152
src/test/regress/expected/int2.out modified +147 −147
src/test/regress/expected/int4.out modified +146 −146
src/test/regress/expected/int8.out modified +239 −239
src/test/regress/expected/interval.out modified +122 −122
src/test/regress/expected/join.out modified +1673 −1673
src/test/regress/expected/name.out modified +75 −75
src/test/regress/expected/numeric.out modified +439 −439
src/test/regress/expected/numerology.out modified +33 −33
src/test/regress/expected/oid.out modified +53 −53
src/test/regress/expected/path.out modified +39 −39
src/test/regress/expected/point.out modified +331 −331
src/test/regress/expected/polygon.out modified +10 −10
src/test/regress/expected/subselect.out modified +81 −81
src/test/regress/expected/text.out modified +5 −5
src/test/regress/expected/timestamp.out modified +1156 −1156
src/test/regress/expected/timestamptz.out modified +1185 −1185
src/test/regress/expected/varchar_1.out modified +56 −56
src/test/regress/expected/varchar_2.out modified +57 −57
src/test/regress/expected/varchar.out modified +56 −56
src/test/regress/input/constraints.source modified +15 −15
src/test/regress/output/constraints.source modified +107 −107
src/test/regress/sql/boolean.sql modified +18 −18
src/test/regress/sql/box.sql modified +18 −18
src/test/regress/sql/case.sql modified +6 −6
src/test/regress/sql/char.sql modified +8 −8
src/test/regress/sql/circle.sql modified +6 −6
src/test/regress/sql/float4.sql modified +15 −15
src/test/regress/sql/float8.sql modified +27 −27
src/test/regress/sql/geometry.sql modified +23 −23
src/test/regress/sql/horology.sql modified +16 −16
src/test/regress/sql/inet.sql modified +9 −9
src/test/regress/sql/int2.sql modified +26 −26
src/test/regress/sql/int4.sql modified +29 −29
src/test/regress/sql/int8.sql modified +27 −27
src/test/regress/sql/interval.sql modified +9 −9
src/test/regress/sql/join.sql modified +31 −31
src/test/regress/sql/name.sql modified +11 −11
src/test/regress/sql/numeric.sql modified +58 −58
src/test/regress/sql/numerology.sql modified +3 −3
src/test/regress/sql/oid.sql modified +7 −7
src/test/regress/sql/path.sql modified +4 −4
src/test/regress/sql/point.sql modified +16 −16
src/test/regress/sql/polygon.sql modified +1 −1
src/test/regress/sql/subselect.sql modified +10 −10
src/test/regress/sql/text.sql modified +1 −1
src/test/regress/sql/timestamp.sql modified +22 −22
src/test/regress/sql/timestamptz.sql modified +25 −25
src/test/regress/sql/varchar.sql modified +8 −8

Discussion