WAL-log inplace update before revealing it to other sessions.

Noah Misch <noah@leadboat.com>

Commit: bfd5c6e279c8e1702eea882439dc7ebdf4d4b3a5
Author: Noah Misch <noah@leadboat.com>
Date: 2024-10-25T13:51:06Z
Releases: 17.1
WAL-log inplace update before revealing it to other sessions.

A buffer lock won't stop a reader having already checked tuple
visibility.  If a vac_update_datfrozenid() and then a crash happened
during inplace update of a relfrozenxid value, datfrozenxid could
overtake relfrozenxid.  That could lead to "could not access status of
transaction" errors.  Back-patch to v12 (all supported versions).  In
v14 and earlier, this also back-patches the assertion removal from
commit 7fcf2faf9c7dd473208fd6d5565f88d7f733782b.

Discussion: https://postgr.es/m/20240620012908.92.nmisch@google.com

Files

PathChange+/−
src/backend/access/heap/heapam.c modified +45 −13
src/backend/access/heap/README.tuplock modified +1 −3

Discussion