Make OIDs optional, per discussions in pghackers. WITH OIDS is still the

Tom Lane <tgl@sss.pgh.pa.us>

Commit: bf56f0759bdfa87f143c3abd09f893a5f530fe88
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2001-08-10T18:57:42Z
Releases: 7.2.1
Make OIDs optional, per discussions in pghackers.  WITH OIDS is still the
default, but OIDS are removed from many system catalogs that don't need them.
Some interesting side effects: TOAST pointers are 20 bytes not 32 now;
pg_description has a three-column key instead of one.

Bugs fixed in passing: BINARY cursors work again; pg_class.relhaspkey
has some usefulness; pg_dump dumps comments on indexes, rules, and
triggers in a valid order.

initdb forced.

Files

PathChange+/−
contrib/chkpass/chkpass.sql modified +2 −4
contrib/findoidjoins/findoidjoins.c modified +5 −7
contrib/findoidjoins/make_oidjoins_check modified +2 −2
contrib/findoidjoins/README.findoidjoins modified +9 −7
contrib/intarray/_int.sql.in modified +5 −20
doc/src/sgml/catalogs.sgml modified +50 −13
doc/src/sgml/ref/create_table.sgml modified +71 −3
doc/src/sgml/syntax.sgml modified +26 −7
src/backend/access/heap/heapam.c modified +17 −21
src/backend/access/heap/tuptoaster.c modified +29 −33
src/backend/access/transam/varsup.c modified +24 −6
src/backend/access/transam/xlog.c modified +1 −3
src/backend/bootstrap/bootparse.y modified +23 −16
src/backend/bootstrap/bootscanner.l modified +3 −1
src/backend/bootstrap/bootstrap.c modified +5 −4
src/backend/catalog/catalog.c modified +5 −16
src/backend/catalog/genbki.sh modified +41 −24
src/backend/catalog/heap.c modified +53 −53
src/backend/catalog/index.c modified +39 −12
src/backend/catalog/indexing.c modified +2 −2
src/backend/commands/cluster.c modified +6 −3
src/backend/commands/command.c modified +45 −39
src/backend/commands/comment.c modified +256 −200
src/backend/commands/copy.c modified +59 −37
src/backend/commands/creatinh.c modified +15 −6
src/backend/commands/dbcommands.c modified +4 −4
src/backend/commands/indexcmds.c modified +2 −2
src/backend/commands/remove.c modified +11 −21
src/backend/commands/sequence.c modified +3 −2
src/backend/commands/trigger.c modified +5 −9
src/backend/commands/vacuum.c modified +9 −2
src/backend/commands/vacuumlazy.c modified +3 −2
src/backend/commands/view.c modified +3 −2
src/backend/executor/execMain.c modified +2 −2
src/backend/nodes/copyfuncs.c modified +3 −2
src/backend/nodes/equalfuncs.c modified +5 −3
src/backend/nodes/outfuncs.c modified +5 −4
src/backend/parser/gram.y modified +11 −4
src/backend/parser/parse_relation.c modified +26 −32
src/backend/rewrite/rewriteRemove.c modified +4 −6
src/backend/utils/cache/relcache.c modified +3 −1
src/backend/utils/cache/syscache.c modified +23 −1
src/bin/initdb/initdb.sh modified +30 −17
src/bin/pg_dump/pg_dump.c modified +99 −62
src/bin/pg_dump/pg_dump.h modified +3 −3
src/bin/psql/describe.c modified +24 −16
src/bin/psql/large_obj.c modified +41 −16
src/include/access/transam.h modified +21 −5
src/include/bootstrap/bootstrap.h modified +2 −2
src/include/catalog/catversion.h modified +2 −2
src/include/catalog/heap.h modified +4 −3
src/include/catalog/index.h modified +4 −3
src/include/catalog/indexing.h modified +6 −4
src/include/catalog/pg_amop.h modified +179 −179
src/include/catalog/pg_amproc.h modified +56 −56
src/include/catalog/pg_attrdef.h modified +1 −1
src/include/catalog/pg_attribute.h modified +151 −149
src/include/catalog/pg_class.h modified +36 −34
src/include/catalog/pg_description.h modified +27 −8
src/include/catalog/pg_group.h modified +2 −2
src/include/catalog/pg_index.h modified +7 −8
src/include/catalog/pg_inherits.h modified +2 −2
src/include/catalog/pg_largeobject.h modified +3 −4
src/include/catalog/pg_listener.h modified +2 −2
src/include/catalog/pg_log.h modified +2 −2
src/include/catalog/pg_proc.h modified +12 −3
src/include/catalog/pg_relcheck.h modified +1 −1
src/include/catalog/pg_shadow.h modified +3 −3
src/include/catalog/pg_statistic.h modified +2 −2
src/include/catalog/unused_oids modified +11 −4
src/include/commands/comment.h modified +8 −5
src/include/nodes/parsenodes.h modified +3 −2
src/include/parser/parse_relation.h modified +1 −2
src/include/postgres.h modified +4 −5
src/include/utils/syscache.h modified +3 −5
src/interfaces/ecpg/preproc/preproc.y modified +10 −4
src/test/regress/expected/oidjoins.out modified +173 −165
src/test/regress/expected/opr_sanity.out modified +27 −47
src/test/regress/expected/rules.out modified +1 −1
src/test/regress/expected/type_sanity.out modified +9 −20
src/test/regress/sql/oidjoins.sql modified +59 −55
src/test/regress/sql/opr_sanity.sql modified +11 −27
src/test/regress/sql/type_sanity.sql modified +3 −12