When expanding a whole-row Var into a RowExpr during ResolveNew(), attach
Tom Lane <tgl@sss.pgh.pa.us>
When expanding a whole-row Var into a RowExpr during ResolveNew(), attach the column alias names of the RTE referenced by the Var to the RowExpr. This is needed to allow ruleutils.c to correctly deparse FieldSelect nodes referencing such a construct. Per my recent bug report. Adding a field to RowExpr forces initdb (because of stored rules changes) so this solution is not back-patchable; which is unfortunate because 8.2 and 8.3 have this issue. But it only affects EXPLAIN for some pretty odd corner cases, so we can probably live without a solution for the back branches.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/nodes/copyfuncs.c | modified | +2 −1 |
| src/backend/nodes/equalfuncs.c | modified | +2 −1 |
| src/backend/nodes/nodeFuncs.c | modified | +4 −1 |
| src/backend/nodes/outfuncs.c | modified | +2 −1 |
| src/backend/nodes/readfuncs.c | modified | +2 −1 |
| src/backend/optimizer/prep/prepunion.c | modified | +2 −1 |
| src/backend/optimizer/util/var.c | modified | +2 −1 |
| src/backend/parser/parse_coerce.c | modified | +2 −1 |
| src/backend/parser/parse_expr.c | modified | +2 −1 |
| src/backend/rewrite/rewriteManip.c | modified | +6 −3 |
| src/backend/utils/adt/ruleutils.c | modified | +13 −1 |
| src/include/catalog/catversion.h | modified | +2 −2 |
| src/include/nodes/primnodes.h | modified | +8 −1 |