Improve index AMs' opclass validation procedures.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: be44ed27b86ebd165bbedf06a4ac5a8eb943d43c
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2016-01-22T00:47:15Z
Releases: 9.6.0
Improve index AMs' opclass validation procedures.

The amvalidate functions added in commit 65c5fcd353a859da were on the
crude side.  Improve them in a few ways:

* Perform signature checking for operators and support functions.

* Apply more thorough checks for missing operators and functions,
where possible.

* Instead of reporting problems as ERRORs, report most problems as INFO
messages and make the amvalidate function return FALSE.  This allows
more than one problem to be discovered per run.

* Report object names rather than OIDs, and work a bit harder on making
the messages understandable.

Also, remove a few more opr_sanity regression test queries that are
now superseded by the amvalidate checks.

Files