Remove the single-argument form of string_agg(). It added nothing much in
Tom Lane <tgl@sss.pgh.pa.us>
Remove the single-argument form of string_agg(). It added nothing much in functionality, while creating an ambiguity in usage with ORDER BY that at least two people have already gotten seriously confused by. Also, add an opr_sanity test to check that we don't in future violate the newly minted policy of not having built-in aggregates with the same name and different numbers of parameters. Per discussion of a complaint from Thom Brown.
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/func.sgml | modified | +6 −6 |
| doc/src/sgml/syntax.sgml | modified | +6 −5 |
| src/backend/utils/adt/varlena.c | modified | +2 −24 |
| src/include/catalog/catversion.h | modified | +2 −2 |
| src/include/catalog/pg_aggregate.h | modified | +2 −3 |
| src/include/catalog/pg_proc.h | modified | +4 −8 |
| src/include/utils/builtins.h | modified | +1 −5 |
| src/test/regress/expected/aggregates.out | modified | +12 −18 |
| src/test/regress/expected/opr_sanity.out | modified | +25 −0 |
| src/test/regress/sql/aggregates.sql | modified | +5 −6 |
| src/test/regress/sql/opr_sanity.sql | modified | +20 −0 |