Remove RelationGetBufferWithBuffer(), which is horribly confused about

Tom Lane <tgl@sss.pgh.pa.us>

Commit: bdadc9bf1c0900487c372f2403c7c064d177d68c
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2001-06-09T18:16:59Z
Releases: 7.2.1
Remove RelationGetBufferWithBuffer(), which is horribly confused about
appropriate pin-count manipulation, and instead use ReleaseAndReadBuffer.
Make use of the fact that the passed-in buffer (if there is one) must
be pinned to avoid grabbing the bufmgr spinlock when we are able to
return this same buffer.  Eliminate unnecessary 'previous tuple' and
'next tuple' fields of HeapScanDesc and IndexScanDesc, thereby removing
a whole lot of bookkeeping from heap_getnext() and related routines.

Files