pg_logicalinspect: Fix possible crash when passing a directory path.
Masahiko Sawada <msawada@postgresql.org>
pg_logicalinspect: Fix possible crash when passing a directory path. Previously, pg_logicalinspect functions were too trusting of their input and blindly passed it to SnapBuildRestoreSnapshot(). If the input pointed to a directory, the server could a PANIC error while attempting to fsync_fname() with isdir=false on a directory. This commit adds validation checks for input filenames and passes the LSN extracted from the filename to SnapBuildRestoreSnapshot() instead of the filename itself. It also adds regression tests for various input patterns and permission checks. Bug: #18828 Reported-by: Robins Tharakan <tharakan@gmail.com> Co-authored-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Co-authored-by: Masahiko Sawada <sawada.mshk@gmail.com> Discussion: https://postgr.es/m/18828-0f4701c635064211@postgresql.org
Files
| Path | Change | +/− |
|---|---|---|
| contrib/pg_logicalinspect/expected/pg_logicalinspect.out | added | +81 −0 |
| contrib/pg_logicalinspect/Makefile | modified | +1 −0 |
| contrib/pg_logicalinspect/pg_logicalinspect.c | modified | +45 −10 |
| contrib/pg_logicalinspect/sql/pg_logicalinspect.sql | added | +48 −0 |
| src/backend/replication/logical/snapbuild.c | modified | +7 −7 |
| src/include/replication/snapbuild_internal.h | modified | +1 −1 |
Discussion
- BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string 26 messages · 2025-03-01 → 2025-03-13