Horton

Remove pg_constraint.conincluding

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: bd47c4a9d4ec55e26e841754ce62c23ca9008e87
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2018-09-03T15:58:42Z
Releases: 11.0 
Remove pg_constraint.conincluding

This column was added in commit 8224de4f42cc ("Indexes with INCLUDE
columns and their support in B-tree") to ease writing the ruleutils.c
supporting code for that feature, but it turns out to be unnecessary --
we can do the same thing with just one more syscache lookup.

Even the documentation for the new column being removed in this commit
is awkward.

Discussion: https://postgr.es/m/20180902165018.33otxftp3olgtu4t@alvherre.pgsql

Files

PathChange+/−
doc/src/sgml/catalogs.sgml modified +0 −8
src/backend/catalog/pg_constraint.c modified +0 −21
src/backend/utils/adt/ruleutils.c modified +45 −12
src/include/catalog/catversion.h modified +1 −1
src/include/catalog/pg_constraint.h modified +0 −6
src/test/regress/expected/index_including.out modified +20 −20
src/test/regress/sql/index_including.sql modified +5 −5

Documentation touched

Discussion