Use binary search instead of brute-force scan in findNamespace().

Tom Lane <tgl@sss.pgh.pa.us>

Commit: bd43c50a5bd560224f996d6bd14e1e3cb5a5b06b
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-05-25T18:35:59Z
Releases: 8.3.19
Use binary search instead of brute-force scan in findNamespace().

The previous coding presented a significant bottleneck when dumping
databases containing many thousands of schemas, since the total time
spent searching would increase roughly as O(N^2) in the number of objects.
Noted by Jeff Janes, though I rewrote his proposed patch to use the
existing findObjectByOid infrastructure.

Since this is a longstanding performance bug, backpatch to all supported
versions.

Files

PathChange+/−
src/bin/pg_dump/common.c modified +16 −3
src/bin/pg_dump/pg_dump.c modified +17 −22
src/bin/pg_dump/pg_dump.h modified +1 −0