Add missing bad-PGconn guards in libpq entry points.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: bb9237a1295a29c4e41b97f9d34e3922ac69c071
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2022-08-15T19:40:07Z
Releases: 16.0
Add missing bad-PGconn guards in libpq entry points.

There's a convention that externally-visible libpq functions should
check for a NULL PGconn pointer, and fail gracefully instead of
crashing.  PQflush() and PQisnonblocking() didn't get that memo
though.  Also add a similar check to PQdefaultSSLKeyPassHook_OpenSSL;
while it's not clear that ordinary usage could reach that with a
null conn pointer, it's cheap enough to check, so let's be consistent.

Daniele Varrazzo and Tom Lane

Discussion: https://postgr.es/m/CA+mi_8Zm_mVVyW1iNFgyMd9Oh0Nv8-F+7Y3-BqwMgTMHuo_h2Q@mail.gmail.com

Files

Discussion