Horton

Improve error checking of CREATE COLLATION options.

Dean Rasheed <dean.a.rasheed@gmail.com>

View on postgr.es
Commit: ba620760c4c8ca90ff83ecf7e4d46f5ec4dabd7b
Author: Dean Rasheed <dean.a.rasheed@gmail.com>
Date: 2021-07-18T10:08:34Z
Releases: 15.0 
Improve error checking of CREATE COLLATION options.

Check for conflicting or redundant options, as we do for most other
commands. Specifying any option more than once is at best redundant,
and quite likely indicates a bug in the user's code.

While at it, improve the error for conflicting locale options by
adding detail text (the same as for CREATE DATABASE).

Bharath Rupireddy, reviewed by Vignesh C. Some additional hacking by
me.

Discussion: https://postgr.es/m/CALj2ACWtL6fTLdyF4R_YkPtf1YEDb6FUoD5DGAki3rpD+sWqiA@mail.gmail.com

Files

PathChange+/−
src/backend/commands/collationcmds.c modified +12 −5
src/test/regress/expected/collate.out modified +47 −0
src/test/regress/sql/collate.sql modified +21 −0

Discussion