Fix plan cache issue in PL/pgSQL CALL

Peter Eisentraut <peter_e@gmx.net>

Commit: b9986551e0c6129300b9d7a387baf2006724b297
Author: Peter Eisentraut <peter_e@gmx.net>
Date: 2018-04-05T18:51:56Z
Releases: 11.0
Fix plan cache issue in PL/pgSQL CALL

If we are not going to save the plan, then we need to unset expr->plan
after we are done, also in error cases.  Otherwise, we get a dangling
pointer next time around.

This is not the ideal solution.  It would be better if we could convince
SPI not to associate a cached plan with a resource owner, and then we
could just save the plan in all cases.  But that would require bigger
surgery.

Reported-by: Pavel Stehule <pavel.stehule@gmail.com>

Files