Fix crash in postgres_fdw for provably-empty remote UPDATE/DELETE.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: b9734c13f168ef0d487aa122e486ca9b6dd6aa59
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-07-07T19:21:25Z
Releases: 15.0
Fix crash in postgres_fdw for provably-empty remote UPDATE/DELETE.

In 86dc90056, I'd written find_modifytable_subplan with the assumption
that if the immediate child of a ModifyTable is a Result, it must be
a projecting Result with a subplan.  However, if the UPDATE or DELETE
has a provably-constant-false WHERE clause, that's not so: we'll
generate a dummy subplan with a childless Result.  Add the missing
null-check so we don't crash on such cases.

Per report from Alexander Pyhalov.

Discussion: https://postgr.es/m/b9a6f53549456b2f3e2fd150dcd79d72@postgrespro.ru

Files

Discussion