Windows: Make pg_ctl reliably detect service status

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: b96f6f4443fcc68336c7ed45e470c577a4891c00
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2016-01-07T14:59:08Z
Releases: 9.1.20
Windows: Make pg_ctl reliably detect service status

pg_ctl is using isatty() to verify whether the process is running in a
terminal, and if not it sends its output to Windows' Event Log ... which
does the wrong thing when the output has been redirected to a pipe, as
reported in bug #13592.

To fix, make pg_ctl use the code we already have to detect service-ness:
in the master branch, move src/backend/port/win32/security.c to src/port
(with suitable tweaks so that it runs properly in backend and frontend
environments); pg_ctl already has access to pgport so it Just Works.  In
older branches, that's likely to cause trouble, so instead duplicate the
required code in pg_ctl.c.

Author: Michael Paquier
Bug report and diagnosis: Egon Kocjan
Backpatch: all supported branches

Files

PathChange+/−
src/bin/pg_ctl/pg_ctl.c modified +159 −1