Horton

Move EEOP_*_SYSVAR evaluation out of line.

Andres Freund <andres@anarazel.de>

View on postgr.es
Commit: b84a6dafbf2bb921baee53c0c1aba7719ee38817
Author: Andres Freund <andres@anarazel.de>
Date: 2018-11-07T19:08:45Z
Releases: 12.0 
Move EEOP_*_SYSVAR evaluation out of line.

This mainly de-duplicates code. As evaluating a system variable isn't
the hottest path and the current inline implementation ends up calling
out to an external function anyway, this is OK from a performance POV.

The main motivation for de-duplicating is the upcoming slot
abstraction work, after which there's not guaranteed to be a HeapTuple
backing the slot.

Author: Andres Freund, Amit Khandekar
Discussion: https://postgr.es/m/20181105210039.hh4vvi4vwoq5ba2q@alap3.anarazel.de

Files

PathChange+/−
src/backend/executor/execExprInterp.c modified +19 −39
src/backend/jit/llvm/llvmjit.c modified +2 −2
src/backend/jit/llvm/llvmjit_expr.c modified +8 −30
src/backend/jit/llvm/llvmjit_types.c modified +1 −1
src/include/executor/execExpr.h modified +2 −0
src/include/jit/llvmjit.h modified +1 −1

Discussion