Horton

Fix bug in detecting concurrent page splits in GiST insert

Heikki Linnakangas <heikki.linnakangas@iki.fi>

View on postgr.es
Commit: b8403d140f4e7d753d21116c0fa79dc4ca5ca5cb
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: 2021-01-20T09:58:25Z
Releases: 13.2 
Fix bug in detecting concurrent page splits in GiST insert

In commit 9eb5607e699, I got the condition on checking for split or
deleted page wrong: I used && instead of ||. The comment correctly said
"concurrent split _or_ deletion".

As a result, GiST insertion could miss a concurrent split, and insert to
wrong page. Duncan Sands demonstrated this with a test script that did a
lot of concurrent inserts.

Backpatch to v12, where this was introduced. REINDEX is required to fix
indexes that were affected by this bug.

Backpatch-through: 12
Reported-by: Duncan Sands
Discussion: https://www.postgresql.org/message-id/a9690483-6c6c-3c82-c8ba-dc1a40848f11%40deepbluecap.com

Files

PathChange+/−
src/backend/access/gist/gist.c modified +4 −1

Discussion