Horton

Fix misbehavior of DROP OWNED BY with duplicate polroles entries.

Tom Lane <tgl@sss.pgh.pa.us>

View on postgr.es
Commit: b7e3a440775b6595ede98878f8a971a92364cf4d
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-06-18T22:00:09Z
Releases: 10.18 
Fix misbehavior of DROP OWNED BY with duplicate polroles entries.

Ordinarily, a pg_policy.polroles array wouldn't list the same role
more than once; but CREATE POLICY does not prevent that.  If we
perform DROP OWNED BY on a role that is listed more than once,
RemoveRoleFromObjectPolicy either suffered an assertion failure
or encountered a tuple-updated-by-self error.  Rewrite it to cope
correctly with duplicate entries, and add a CommandCounterIncrement
call to prevent the other problem.

Per discussion, there's other cleanup that ought to happen here,
but this seems like the minimum essential fix.

Per bug #17062 from Alexander Lakhin.  It's been broken all along,
so back-patch to all supported branches.

Discussion: https://postgr.es/m/17062-11f471ae3199ca23@postgresql.org

Files

PathChange+/−
src/backend/commands/policy.c modified +27 −23
src/test/regress/expected/rowsecurity.out modified +9 −0
src/test/regress/sql/rowsecurity.sql modified +10 −0

Discussion