Make src/common/exec.c's error logging less ugly.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: b6b297d20df9f738be20a450f80bade535819220
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2018-10-09T17:36:24Z
Releases: 12.0
Make src/common/exec.c's error logging less ugly.

This code used elog where it really ought to use ereport, mainly so that
it can report a SQLSTATE different from ERRCODE_INTERNAL_ERROR.  There
were some other random deviations from typical error report practice too.

In addition, we can make some cleanups that were impractical six months
ago:

* Use one variadic macro, instead of several with different numbers
of arguments, reducing the temptation to force-fit messages into
particular numbers of arguments;

* Use %m, even in the frontend case, simplifying the code.

Discussion: https://postgr.es/m/6025.1527351693@sss.pgh.pa.us

Files

PathChange+/−
src/common/exec.c modified +72 −52

Discussion