Horton

Don't read fields of a misaligned ExpandedObjectHeader or AnyArrayType.

Noah Misch <noah@leadboat.com>

View on postgr.es
Commit: b664b187d7ea6546ef4e0f32167a93c6a74dca08
Author: Noah Misch <noah@leadboat.com>
Date: 2019-07-01T00:34:21Z
Releases: 9.5.19 
Don't read fields of a misaligned ExpandedObjectHeader or AnyArrayType.

UBSan complains about this.  Instead, cast to a suitable type requiring
only 4-byte alignment.  DatumGetAnyArrayP() already assumes one can cast
between AnyArrayType and ArrayType, so this doesn't introduce a new
assumption.  Back-patch to 9.5, where AnyArrayType was introduced.

Reviewed by Tom Lane.

Discussion: https://postgr.es/m/20190629210334.GA1244217@rfd.leadboat.com

Files

PathChange+/−
src/backend/utils/adt/arrayfuncs.c modified +1 −1
src/include/utils/arrayaccess.h modified +2 −2
src/include/utils/array.h modified +13 −6
src/include/utils/expandeddatum.h modified +1 −1

Discussion