Fix some shadow variables in src/backend/replication/

Michael Paquier <michael@paquier.xyz>

Commit: b5934bfd6071fed3a38cea0cfaa93afda63d9c0c
Author: Michael Paquier <michael@paquier.xyz>
Date: 2023-08-30T23:07:48Z
Releases: 17.0
Fix some shadow variables in src/backend/replication/

The code is able to compile already without warnings under
-Wshadow=compatible-local, which is itself already enabled in the tree,
and the ones fixed here showed up with the more restrictive -Wshadow.

There are more of these that we may want to look at, and the ones fixed
here made the code confusing.

Author: Peter Smith
Discussion: https://postgr.es/m/CAHut+PuR0y4ofNOxi691VTVWmBfScHV9AaBMGSpeh8+DKp81Nw@mail.gmail.com

Files

Discussion