Fix crash with RemoveFromWaitQueue() when detecting a deadlock.
Masahiko Sawada <msawada@postgresql.org>
Fix crash with RemoveFromWaitQueue() when detecting a deadlock. Commit 5764f611e used dclist_delete_from() to remove the proc from the wait queue. However, since it doesn't clear dist_node's next/prev to NULL, it could call RemoveFromWaitQueue() twice: when the process detects a deadlock and then when cleaning up locks on aborting the transaction. The waiting lock information is cleared in the first call, so it led to a crash in the second call. Backpatch to v16, where the change was introduced. Bug: #18031 Reported-by: Justin Pryzby, Alexander Lakhin Reviewed-by: Andres Freund Discussion: https://postgr.es/m/ZKy4AdrLEfbqrxGJ%40telsasoft.com Discussion: https://postgr.es/m/18031-ebe2d08cb405f6cc@postgresql.org Backpatch-through: 16
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/storage/lmgr/lock.c | modified | +1 −1 |
Discussion
- BUG #18031: Segmentation fault after deadlock within VACUUM's parallel worker 8 messages · 2023-07-19 → 2023-07-26
- pg16b2: REINDEX segv on null pointer in RemoveFromWaitQueue 3 messages · 2023-07-11 → 2023-07-24