In array_agg(), don't create a new context for every group.

Jeff Davis <jdavis@postgresql.org>

Commit: b419865a814abbca12bdd6eef6a3d5ed67f432e1
Author: Jeff Davis <jdavis@postgresql.org>
Date: 2015-02-22T01:24:48Z
Releases: 9.5.0
In array_agg(), don't create a new context for every group.

Previously, each new array created a new memory context that started
out at 8kB. This is incredibly wasteful when there are lots of small
groups of just a few elements each.

Change initArrayResult() and friends to accept a "subcontext" argument
to indicate whether the caller wants the ArrayBuildState allocated in
a new subcontext or not. If not, it can no longer be released
separately from the rest of the memory context.

Fixes bug report by Frank van Vugt on 2013-10-19.

Tomas Vondra. Reviewed by Ali Akbar, Tom Lane, and me.

Files