Horton

Fix parallel restore of FKs to partitioned tables

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: b304b2b65fde057a35286adf3ea69f5e154d1878
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2019-10-17T07:58:01Z
Releases: 12.1 
Fix parallel restore of FKs to partitioned tables

When an FK constraint is created, it needs the index on the referenced
table to exist and be valid.  When doing parallel pg_restore and the
referenced table was partitioned, this condition can sometimes not be
met, because pg_dump didn't emit sufficient object dependencies to
ensure so; this means that parallel pg_restore would fail in certain
conditions.  Fix by having pg_dump make the FK constraint object
dependent on the partition attachment objects for the constraint's
referenced index.

This has been broken since f56f8f8da6af, so backpatch to Postgres 12.

Discussion: https://postgr.es/m/20191005224333.GA9738@alvherre.pgsql

Files

PathChange+/−
src/bin/pg_dump/common.c modified +3 −0
src/bin/pg_dump/pg_dump.c modified +40 −2
src/bin/pg_dump/pg_dump.h modified +2 −0
src/fe_utils/simple_list.c modified +21 −0
src/include/fe_utils/simple_list.h modified +16 −3

Discussion