Horton

Unify drop-by-OID functions

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: b1d32d3e3230f00b5baba08f75b4f665c7d6dac6
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2020-06-09T07:39:46Z
Releases: 14.0 
Unify drop-by-OID functions

There are a number of Remove${Something}ById() functions that are
essentially identical in structure and only different in which catalog
they are working on.  Refactor this to be one generic function.  The
information about which oid column, index, etc. to use was already
available in ObjectProperty for most catalogs, in a few cases it was
easily added.

Reviewed-by: Pavel Stehule <pavel.stehule@gmail.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/331d9661-1743-857f-1cbb-d5728bcd62cb%402ndquadrant.com

Files

PathChange+/−
src/backend/catalog/aclchk.c modified +0 −33
src/backend/catalog/dependency.c modified +76 −84
src/backend/catalog/objectaddress.c modified +98 −1
src/backend/catalog/pg_collation.c modified +0 −36
src/backend/catalog/pg_conversion.c modified +0 −33
src/backend/commands/amcmds.c modified +0 −27
src/backend/commands/event_trigger.c modified +0 −22
src/backend/commands/foreigncmds.c modified +0 −71
src/backend/commands/functioncmds.c modified +0 −53
src/backend/commands/opclasscmds.c modified +0 −99
src/backend/commands/proclang.c modified +0 −22
src/backend/commands/publicationcmds.c modified +0 −23
src/backend/commands/schemacmds.c modified +0 −23
src/backend/commands/tsearchcmds.c modified +0 −71
src/include/catalog/objectaddress.h modified +1 −0
src/include/catalog/pg_collation.h modified +0 −1
src/include/catalog/pg_conversion.h modified +0 −1
src/include/commands/defrem.h modified +0 −13
src/include/commands/event_trigger.h modified +0 −1
src/include/commands/proclang.h modified +0 −1
src/include/commands/publicationcmds.h modified +0 −1
src/include/commands/schemacmds.h modified +0 −2
src/include/utils/acl.h modified +0 −1

Discussion